Autowiring Madness

In this chapter, 2 code portions are different. Why ?

`<?php

namespace AppBundle\Twig;

use AppBundle\Service\MarkdownTransformer;

class MarkdownExtension extends \Twig_Extension
{

private $markdownTransformer;

public function __construct(MarkdownTransformer $markdownTransformer)
{
    $this->markdownTransformer = $markdownTransformer;
}

public function getFilters()
{
    return [
        new \Twig_SimpleFilter('markdownify', array($this, 'parseMarkdown'))
    ];
}

public function parseMarkdown($str)
{
    return $this->markdownTransformer->parse($str);
}

public function getName()
{
    return 'app_markdown';
}

}
<br />then<br /><?php

namespace AppBundle\Twig;

use AppBundle\Service\MarkdownParser;

class MarkdownExtension extends \Twig_Extension
{

private $markdownParser;

public function __construct(MarkdownParser $markdownParser)
{
    $this->markdownParser = $markdownParser;
}

public function getFilters()
{
    return [
        new \Twig_SimpleFilter('markdownify', array($this, 'parseMarkdown'), [
            'is_safe' => ['html']
        ])
    ];
}

public function parseMarkdown($str)
{
    return $this->markdownParser->parse($str);
}

public function getName()
{
    return 'app_markdown';
}

}
`
markdownTransformer ---> markdownParser.
Without explications ? Maybe a relic ?

Hey Alexandre P.

I don't know what are you talking about... cough, cough, I just fixed it, we were showing a wrong code block... cough, cough

Thanks for informing us. Cheers!

Hey there there

are there any plans to delve deeper into this topic? (SOA in symfony) ? It was a wonderful topic, yet we just scratched the surface and it felt a VERY important topic to master.

I totally agree on both points. But I'm not sure *what* else might be useful to cover. In its simplest sense, it's "put logic into services!" and this tutorial showed the mechanics for doing that. If we can think of a few concrete items that would be helpful, then yea - let's do a tutorial on it :)

I'll give it some thought and let you know, as indeed, I think this should be explained further, deeply explored, maybe a tutorial with a more hands on, real life situation would help, who knows. Disquss integration for a blog, or a simple "invoice" manager (not a billing system, but a invoice generator, where you mark them as pending, unpaid, canceled, paid, offer printable version, pdf export, send through email, whatever, just blabling on the-spot ideas)

I am exploring https://github.com/orocrm/crm and I am confused about the dir structure. What the heck are DependencyInjection and Model directories in Bundles? Do we have any vid on this topic here?

Hey,

Ah, DependencyInjection is the most mystery dir in bundle structure at first sight :). First of all you need to understand what is a Symfony bundle. You could also check this course, which explains basic things about this directory. In short, this helps to plug in third-party bundles in your application (imports services, routes, configuration, etc.).

Usually, model is a simple data class which you used in code. It looks like an entity, but doesn't store in DB (doesn't handle with Doctrine). Frequently, in Symfony projects, models uses in form type as data classes.

Cheers!

Hello
In the course the course Symfony: Level up with Services and the Container observed that it does not match the Code of the course downloaded.
For example it speaks of the entity Genus and shows and edits its content but nda to do with the development that I followed in the 7 chapters.
Is there something wrong I've done or should I download other content?
regards

Hey Eduardo Guglielmotti

When you download the code, it contains 2 folders (start and finish).
The start folder is for the very beginning of this course, it doesn't contain the code of further chapters
And the finish folder contains every line wrote in this course.

I hope this clarifies the thing a bit :)

Have a nice day.

OK thanks

I'm clearing that I'm testing on symfony 3.3

I'm having some trouble using the new Symfony 3.3 autowiring feature with my entity repositories. Currently, I am trying to pass in instances of Doctrine\ORM\EntityManagerInterface, Doctrine\ORM\Mapping\ClassMetadata, and a custom boolean parameter I am manually configuring. However, when I attempt to use this repository I receive the following error:
Too few arguments to function AppBundle\Entity\UserRepository::__construct(), 2 passed in /vendor/doctrine/orm/lib/Doctrine/ORM/Repository/DefaultRepositoryFactory.php on line 68 and exactly 3 expected
When I remove this custom parameter, the repository works again. Any hints?

Hey Jonah Mandli!

Yea..... this isn't very easy to do right now :). Entity repositories cannot be autowired easily. It's actually something I'm working on right now in DoctrineBundle - https://github.com/symfony/symfony/issues/24775 - and hopefully it will be merged!

Currently, the problem is that the entity manager (via $em->getRepository()) is actually the "thing" that is responsible for creating your repository. You cannot configure it like a normal service (even if you could get the __construct arguments correct) because then you might have two instances of your repository "floating" around - (1) an instance if you fetch it from the container and (2) another instance of you (or someone) calls $em->getRepository().

So, if you want to register your repositories as services, you must use this factory method - see the answer here: https://stackoverflow.com/questions/38505002/how-to-configure-dependency-injection-for-repository-class-in-symfony-3

The downside is that this is a very manual process :/. That's what I'm hoping we can fix in the next version of DoctrineBundle. For now, in my projects, I often inject the EntityManager into my services and use $this->em->getRepository() to get my repository instead of trying to inject just my repository directly. And how do I pass extra constructor arguments to my repositories? I don't! Usually (but not always) if my repository needs more configuration, then I might be putting too much in my repository. I instead create a separate service (e.g. BlogPostManager instead of BlogPostRepository), pass my custom config and the EM into that service, and do my work :).

So, that's "bad" news for you now... but hopefully we will have good news in the future!

Cheers!

Thanks for the quick response! I'll keep my ear to the ground on any new developments for this feature.

i have an autowiring error i couldnt fix it someone please help me?

                                    (1/1)
                                    AutowiringFailedException
                                
                                

Cannot
autowire service "AppBundle\Service\MarkdownTransformer": argument
"$markdownParser" of method "__construct()" references interface
"Knp\Bundle\MarkdownBundle\MarkdownParserInterface" but no such service
exists. You should maybe alias this interface to one of these existing
services: "markdown.parser.min", "markdown.parser.light",
"markdown.parser.medium", "markdown.parser.max",
"markdown.parser.flavored".

i have no idea how to change my services.yml it looks like this

app.markdown_transformer:
    class: AppBundle\Service\MarkdownTransformer
    public: true
    arguments: ['@markdown.parser', '@doctrine_cache.providers.my_markdown_cache']

app.markdown_extension:
    class: AppBundle\Twig\MarkdownExtension
    public: true
    tags:
        - { name: twig.extension }
    arguments: ['@app.markdown_transformer']

i solved my problem if anybody have same error add the lines below add this

app.markdown_transformer:
class: AppBundle\Service\MarkdownTransformer
public: true
arguments: ['@markdown.parser', '@doctrine_cache.providers.my_markdown_cache']
# add this
AppBundle\Service\MarkdownTransformer: '@app.markdown_transformer'

app.markdown_extension:
class: AppBundle\Twig\MarkdownExtension
public: true
tags:
- { name: twig.extension }
arguments: ['@app.markdown_transformer']

Hey msthzn !

I think I know the cause, and it can be confusing :). In Symfony 3.3, we (meaning Symfony) added some extra, default configuration to services.yml which enabled a bunch of autowiring features, but this tutorial was recorded before Symfony 3.3. So basically, your version of the code has these new, optional autowiring features enabled, which is making things not match what we're doing in the tutorial. We *are* doing some autowiring (obviously, this chapter is about autowiring), but the new config in services.yml in Symfony 3.3 takes it to another level :). We have a blog post about this: https://knpuniversity.com/b.... Basically, if you want to avoid issues and follow along exactly, you can just comment-out those new items in services.yml.

And don't worry too much about the new stuff while going through this tutorial! We talk about it in this tutorial: https://knpuniversity.com/s.... And at the end of the year when Symfony 4 comes out, we will talk A LOT more about all of this cool stuff :).

Cheers!

While interviewing for few jobs I was asked about implementing a service bus. I understand DIP and services. However, I cant see how a service bus could be implemented. Do you guys from Knp, know of an example of service bus and its use case. Possibly, using RabbitMQ?

Any idea about this error:

Fatal error: Uncaught Symfony\Component\DependencyInjection\Exception\AutowiringFailedException: Cannot autowire service "AppBundle\Service\MarkdownTransformer": argument "$markdownParser" of method "__construct()" references interface "Knp\Bundle\MarkdownBundle\MarkdownParserInterface" but no such service exists. You should maybe alias this interface to one of these existing services: "markdown.parser.min", "markdown.parser.light", "markdown.parser.medium", "markdown.parser.max", "markdown.parser.flavored". in C:\Users\pkourtellos\Desktop\Php stuff\aqua_note\vendor\symfony\symfony\src\Symfony\Component\DependencyInjection\Compiler\AutowirePass.php:291
Stack trace:
#0 C:\Users\pkourtellos\Desktop\Php stuff\aqua_note\vendor\symfony\symfony\src\Symfony\Component\DependencyInjection\Compiler\AutowirePass.php(223): Symfony\Component\DependencyInjection\Compiler\AutowirePass->autowireMethod(Object(ReflectionMethod), Array)
#1 C:\Users\pkourtellos\Desktop\Php stuff\aqua_note\vendor\symfony\symfony\src\Symfony\Component\Dependen in C:\Users\pkourtellos\Desktop\Php stuff\aqua_note\vendor\symfony\symfony\src\Symfony\Component\DependencyInjection\Compiler\AutowirePass.php on line 291

I've even taken out autowire=true from services.yml

Hey Praxitelis Kourtellos

I believe you are trying to autowire the service "app.markdown_transformer", but that's not correct, you should autowire the other service "app.markdown_extension", if I'm wrong, can you show me your services.yml file ?

Cheers!

I have the same problem. And I believe it is only for the latest symphony 3.3.2.

Hey Wei Dai

Symfony 3.3 changed a lot of things about autowiring and the container, we have a dedicated tutorial just in case you want to go deeper https://knpuniversity.com/s...

If you run "bin/console debug:container --types" you can see all the classes that your container knows about, so you can find which ones are for the MarkdownParser, and then, define an alias that you can inject into your service.
You can filter the list by running this: "bin/console debug:container --types | grep Markdown "

Cheers!

After run the console command, the container doesn't know any classes from the Knp markdown bundle. I think the reason is because the bundle is built for previous symfony version, and all service makred as non-public?
The container can only know the customer classes we defined.

solved. Thanks for the tutorial.

Hey there, I noticed that sometimes you use `array()` syntax for PHP arrays, and sometimes (most of the time) square brackets notation. Do you have some logic for using one over the other?

Yo Serge!

Good catch! Short array syntax, i.e. square brackets, is just a new syntax since PHP 5.4 and we're trying to use it in our all new screencasts. So it's just a matter of habit if you see Ryan writes old syntax sometimes. But they are both do the same.

Cheers!

Thanks victor!

That's what I thought. Personally, I like the square brackets notation syntax much more and the only valid reason to use `array()` for me was if production PHP version is < 5.4. Fortunately, it's a rare situation nowadays. :)

Yes, absolutely agree! Well, I think old array syntax occurred sometimes due to copy/paste some example code from docs and when you're lazy enough to tweak it :D

Btw, I like "[]" because it's the same syntax which is used in JS, so double win!

Cheers!