The HTTP Client Service

Hey Marc!

Hmm, that's weird - I can't think of a reason! As long as you have the http_client enabled (which should happen automatically when you install that package) and the profiler (which you DO have if you are seeing the web debug toolbar), then it should be there. The logic that loads it is here - https://github.com/symfony/symfony/blob/0383b067e947efb3570b2fda8259e582ef3d8f2d/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php#L846-L848 - but that's super deep and complex, so not sure that's helpful. But it basically says what I just said: as long as profiler and http_client are enabled, that web debug toolbar should be there.

Oh, actually, there is one other possibility: there were no requests issued during the request by the HTTP client. If that happens, the web debug toolbar icon won't be shown - https://github.com/symfony/symfony/blob/0383b067e947efb3570b2fda8259e582ef3d8f2d/src/Symfony/Bundle/WebProfilerBundle/Resources/views/Collector/http_client.html.twig#L40 - but if you clicked any of the other icons to get into the profiler, I think you would still see an "HTTP Client" section.

Let me know if this helps!

Cheers!

Hi Ryan,

Thanks for your answer.
The fact is I tweaked http_client.html.twig to display {{ collector.requestCount }} value. It stays at 0 though dumping the result of

$response = $httpClient->request(
            'GET',
            'https://raw.githubusercontent.com/SymfonyCasts/vinyl-mixes/main/mixes.json?'
        );

via dump($response) outputs :

Symfony\Component\HttpClient\Response\TraceableResponse {#2284 ▼
  -client: Symfony\Component\HttpClient\CurlHttpClient {#6639 ▶}
  -response: Symfony\Component\HttpClient\Response\CurlResponse {#6264 ▶}
  -content: & null
  -event: Symfony\Component\Stopwatch\StopwatchEvent {#6169 ▶}
}

By the way, dumping $response->toArray() outputs the desired array.

Would you have an idea how we can get the valid response content with no request done ?
Would there be an internal cache ?

In composer.json, http-client is version 6.2.6

Kind regards,

Marc.

Hey Marc!

That's some good debugging! Hmm. A few things to check out... though I don't think these are the cause (but I need to check anyways):

A) You are autowiring the HttpClient service the same way we do in the tutorial?
B) Are you actually using the result of the response? I'm asking because the HttpClient is "async". So if you simply made a request, but never used its response, then it's possible that the response hasn't actually finished by the time the profiler collects the data. However, if you are even calling $response->toArray(), then that makes the code "wait" for the request to finish... and so that would be enough to avoid this.

So then, what could the cause be? I'm not sure - it definitely looks weird :/

I'm interested also if:

1) Is this method being called https://github.com/symfony/symfony/blob/0383b067e947efb3570b2fda8259e582ef3d8f2d/src/Symfony/Component/HttpClient/DataCollector/HttpClientDataCollector.php#L44 ?
2) And if so, what does dd($this->clients) show? It should show at least one HttpClient
3) If your controller, if you dump($httpClient), what does it look like? It should be a TraceableHttpClient. I'm pretty sure it IS because you're getting back a TraceableResponse.

Let me know what you find out :).

Cheers!

Thanks Ryan,

for questions A and B, I can say answer is Yes. Here's the code :

    #[Route('/browse/{slug}', name: 'app_browse')]
    public function browse(HttpClientInterface $httpClient, string $slug = null): Response
    {
        $genre = $slug ? u(str_replace('-', ' ', $slug))->title(true) : null;

        $response = $httpClient->request(
            'GET',
            'https://raw.githubusercontent.com/SymfonyCasts/vinyl-mixes/main/mixes.json',
        );
        dump($response->toArray());
        return $this->render('vinyl/browse.html.twig',
            [
                'genre' => $genre,
                'mixes' => $response->toArray()
            ]);

    }

For points

1. The answer is yes. The method is called twice.
2. dump($this->clients) shows 1 http_client per array (remember the method is called twice), instantiating Symfony\Component\HttpClient\TraceableHttpClient
3. dump($this->httpClient) in the controller gives a Symfony\Component\HttpClient\TraceableHttpClient

I'm really sorry to bother you with this.

Thanks!

Huh... so everything, so far, seems to be working 100% correctly!

So. you have confirmed that lateCollect() is called (2x in fact... that may be normal - I'm not sure, I'm not familiar enough with that system) - https://github.com/symfony/symfony/blob/0383b067e947efb3570b2fda8259e582ef3d8f2d/src/Symfony/Component/HttpClient/DataCollector/HttpClientDataCollector.php#L44

And we also know that $this->client contains 1 item. So next I would be interested in what $traces looks like - https://github.com/symfony/symfony/blob/0383b067e947efb3570b2fda8259e582ef3d8f2d/src/Symfony/Component/HttpClient/DataCollector/HttpClientDataCollector.php#L51

If there is at least 1 item in $traces, then $this->data['request_count'] would be more than 0. And THEN we should see the icon - thanks to https://github.com/symfony/symfony/blob/0383b067e947efb3570b2fda8259e582ef3d8f2d/src/Symfony/Bundle/WebProfilerBundle/Resources/views/Collector/http_client.html.twig#L40

Actually, in https://github.com/symfony/symfony/blob/0383b067e947efb3570b2fda8259e582ef3d8f2d/src/Symfony/Bundle/WebProfilerBundle/Resources/views/Collector/http_client.html.twig#L40 - you might also try a dump(collector) (outside of any if statements) to make sure this is being called AND what collector looks like.

So, there is a still a mystery here... but we're circling closer and closer to it :).

Cheers!

Hi Ryan,

Thanks for your answer and sorry for the late reply.

Dumping $trace doesn't provide any info, as it gives an empty array.

The most interesting part comes from dumping collector in http_client.html.twig :

Symfony\Component\HttpClient\DataCollector\HttpClientDataCollector {#425 ▼
  #data: array:3 [▼
    "request_count" => 0
    "error_count" => 0
    "clients" => array:2 [▼
      "http_client" => array:2 [▼
        "traces" => []
        "error_count" => 0
      ]
      "githubContentClient" => array:2 [▼
        "traces" => array:1 [▼
          0 => array:7 [▼
            "method" => "GET"
            "url" => "/SymfonyCasts/vinyl-mixes/main/mixes.json"
            "options" => Symfony\Component\VarDumper\Cloner\Data {#433 ▶}
            "content" => array:6 [▶]
            "http_code" => 200
            "info" => Symfony\Component\VarDumper\Cloner\Data {#437 ▶}
            "curlCommand" => """
              curl \
                --compressed \
                --request GET \
                --url 'https://raw.githubusercontent.com/SymfonyCasts/vinyl-mixes/main/mixes.json' \
                --header 'authorization: Token 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' \
                --header 'accept: */*' \
                --header 'user-agent: Symfony HttpClient/Curl' \
                --header 'accept-encoding: gzip'
              """
          ]
        ]
        "error_count" => 0
      ]
    ]
  ]
  -clients: []
}

No clients in clients[], but clients in the #data property.

Would you have an idea ?

If it looks too complicated, we can forget about my question.

Thanks anyway Ryan !

Dang! I am at a loss! How could that clients property be an empty array... and yet $data got populated! Haha, indeed - without being able to play with the code first-hand, I think this will remain a mystery (though, you were an excellent debugging partner). It's possible there is some problem introduced in newer versions of Symfony... or just something bizarre with your setup for some reason. If you DO every happen to find out (maybe it goes away randomly), let me know.

Cheers!

Thanks again Ryan !

I'll let you know in case I solve this stuff...

By the way, congrats to your team : the tutorials are excellent as well as your answers !

Regards,

Marc.

I am having the same issue, also Symfony 6.2.6

Ah, I can repeat it too! This was a bug introduced unintentionally during a CVE security release. The fix has already been merged - https://github.com/symfony/symfony/pull/49301 - it looks like that should land in 6.2.7 when it's released.

Thanks Yard for speaking up - as soon as 2 users had the problem, I knew something must have been wrong!

Hey Jamey-C,

Difficult to say... are you sure you're in the same Symfony environment? I mean, if you tun that code in a Symfony test mode but then look at the latest profile in the browser in Symfony dev mode - you will not see it. Also, I see you're sending a GET request to the "http://kfc.insideria.vip/mixes.json" but on the screenshot I see you're looking at the profile of http://c.com/browse page - those seems like 2 different pages for me :) Btw, that mixes.json file is a real file in your public/ dir? If so - that makes sense you don't see anything in your profiler, because physical files are just served as is, you will only see the requests that are handled by Symfony core in your profiler, i.e. requests to your Symfony controller endpoints, not requests to the physical files.

I hope this helps!

Cheers!