Anotaciones a atributos

Hey Rafael,

Thanks for this tip!

Cheers!

Hey Marcus,

It's difficlult to say for sure especially because your rector.php content is different from the one used in this course, but I will try to help or give you some hints at least. So I see your Rector file is different, was it generated by Rector itself? Could you show your full rector.php file? Also, what Rector version are you using? The Rector version that's used in this tutorial is v0.12.20. If you use that exact version with the content of rector.php shown in this course - I think it should work for you, otherwise you're calling the rector CLI tool incorrectly. What command exactly are you trying to execute? Are you sure you execute that command in the project root dir?

Cheers!

Thanks for the reply Victor. I'm using Rector v1.2.10. I generated the Rector file myself using the Rector documentation. The Rector file works for everything but the annotations. I ran it from the root directory of my project and it successfully modified a large set of file to add return type declarations. Here's the file:

<?php

use Rector\Config\RectorConfig;
use Rector\Php80\Rector\Property\NestedAnnotationToAttributeRector;
use Rector\Php80\ValueObject\AnnotationPropertyToAttributeClass;
use Rector\Php80\Rector\Class_\AnnotationToAttributeRector;
use Rector\Php80\ValueObject\AnnotationToAttribute;
use Rector\Doctrine\Set\DoctrineSetList;
use Rector\Symfony\Set\SensiolabsSetList;
use Rector\Symfony\Set\SymfonySetList;

return RectorConfig::configure()
        ->withPaths([__DIR__ . '/src'])
        ->withPhpSets(php83: true)
        ->withPreparedSets(typeDeclarations: true)
        ->withAttributesSets(symfony: true, doctrine: true)
        ->withSets([
            DoctrineSetList::ANNOTATIONS_TO_ATTRIBUTES,
            SymfonySetList::ANNOTATIONS_TO_ATTRIBUTES,
            SensiolabsSetList::ANNOTATIONS_TO_ATTRIBUTES,
        ])
        ->withSets([
                SymfonySetList::SYMFONY_CODE_QUALITY,
        ])
        ->withConfiguredRule(AnnotationToAttributeRector::class, [
                new AnnotationToAttribute('Symfony\\Component\\Routing\\Annotation\\Route'),
            ])
    ;

I run vendor/bin/rector process src/ and it executes with no changes and the output message [OK] Rector is done!
I have route, cache, and ORM annotations throughout the project and none of them are changes. My directory structure is typical (src/Controllers, src/Entity, etc.).
If you don't see anything obvious in my Rector file, should I try to roll back to the version in this course?

Thanks!

I figured it out thanks to a Stack Overflow post. It has something to do with phpstan which got installed along with Rector. When I remove the phpstan.dist.neon file and then run rector with the --clear-cache option, it works!

Hey @CMarcus ,

Woh, I would not think PhpStan may cause such problems, it sounds weird to me. Glad you figured it out, and thanks for sharing your solution with others!

Cheers!

Hey Loenix,

Do you mean the instructions in this video about how to use Rector are not clear for you? Because it's basically as you said, you need to install Rector in your system in your preferred way (or follow the way we use in this course), then create a configuration for it, and run the Rector to actually do the changes according to the configuration you created. Yeah, you can remove Rector and its config completely after it, or keep the config for the future when you will upgrade your Symfony version, PHPUnit version, or PHP version later - you would just need to tweak the config file... and probably upgrade Rector to the latest, it would be a good idea :)

Cheers!

Yes, It was I meant, I have read this tutorial and the doctrine documentation about it, there was some differences and I was unable to understand what the rector.php file is and where to put it. So I mixed your documentation and try something and it worked, so I though a comment was useful for futur readers.

Hey Loenix,

Thanks for sharing some tips with others. That rector.php file is a config file that will be read by Rector tool telling it what exactly it should do, i.e. it specifies some rules for Rector. And usually, you put such config files in the project root dir, like the PHPUnit config file, etc.

I hope that help!

Cheers!

Hey Cameron!

Very fair suggestion! It's sometimes hard to back up as an instructor and remember all the little details. I can at least give some explanation here. In short, annotations were created around 10 years ago by Doctrine, mostly so that we could add the @ORM\Column annotations inside entities. Other languages have similar syntaxes. Over the years, these got more and more popular, with things like @Route, assertions for validation constraints, etc.

But, annotations were still not part of PHP's language. They're just comments, and Doctrine maintained a library that could read and parse those comments. It worked great, but it's still a bit odd for us to "invent" this new way of adding configuration into the comments system and not have it be part of PHP. And so, someone finally proposed putting into PHP itself. It has a slightly different syntax by necessity: we needed to introduce some new syntax that nobody could possibly be using already in their app (so that the introduction of PHP attributes wouldn't suddenly start making your code do something). Of course, there was a lot of debate on the syntax, and this was finally chosen as a balance between attractive/logical/simple.

I hope that helps - thanks for commenting about this :).

Cheers!

Hi,

Have you tried static function?

#[ApiResource(
    collectionOperations:
        'get',
        'post',
        'count' => YourClassName::getCountActionConfig()
)]

Cheers!

Hello, sorry for delay, yes I tried and no, same problem, I'll have the same error Constant expression contains invalid operations

woh yeah, looks like the only way is to define a constant with the configuration you need and then it will work

I hope so )

Cheers!

Yes, this is so bad. I have to create a separate file that will contain a multitude of constants representing the configurations of my API Platform custom actions. It works, but...

It would be interesting if in a future PHP update we could use functions.

Thanks for your answers anyway!

Agree that's not very useful now, maybe something will change in future, so lets wait =)

Cheers and happy coding!