I replaced the default login form from FOSUserBundle by a form created with the Symfony form builder. Here is the code for this new login form:
`namespace App\Form;
use Symfony\Component\Form\AbstractType; use Symfony\Component\Form\FormBuilderInterface; use Symfony\Component\Form\Extension\Core\Type\EmailType; use Symfony\Component\Form\Extension\Core\Type\PasswordType; use Eo\HoneypotBundle\Form\Type\HoneypotType; use Symfony\Component\OptionsResolver\OptionsResolver;
class LoginFormType extends AbstractType {
public function buildForm(FormBuilderInterface $builder, array $options)
{
$builder
->add('_username', EmailType::class)
->add('_password', PasswordType::class)
->add('companyName', HoneypotType::class)
;
}
public function configureOptions(OptionsResolver $resolver)
{
$resolver->setDefaults([
'translation_domain' => 'FOSUserBundle'
]);
}
}`
Since I'm already generating my form using the Symfony's form builder mechanism, and this one gives me out of the box CSRF protection. Do I still need to get and check the CSRF token in my Guard LoginFormAuthenticator with this?
`$csrfToken = $request->request->get($form->getName())['_token']; if (false === $this->csrfTokenManager->isTokenValid(new CsrfToken('authenticate', $csrfToken))) {
throw new InvalidCsrfTokenException('Invalid CSRF token.');
If you use Symfony Forms for it - it will automatically check the CSRF protection on $form->isValid() call, so as long as you call isValid() method - you don't need to check for CSRF manually, just make sure that the CSRF protection is enabled for that form - you should have that hidden _token field rendered.
Thanks for the feedback! So that means I DO NOT need to check $form->isValid() call inside my `LoginFormAuthenticator` class, my Symfony form will internally check for it as it comes built-in, and enabled by default. Is my assumption correct?
Wait, you do need to call $form->isValid() somewhere before you will extract some data from the submitted form. CSRF protection is checked on isValid() call, and you should call it, Symfony does not call this method internally by itself.
Thanks for clarifying, so it's the opposite from what I was thinking.
Now this prompts me to another question. If $form->isValid() will return me only a boolean (true/false) how can I know exactly what failed in my form? If CSRF protection is what has failed, I want to get a "CSRF invalid token" message on the login form.
I'm looking for something like $form->isValidCSRF() or a way to verify the submitted token by this form which is created using the Symfony's Form builder.
Well, it works in a slightly different way - see form errors instead. You can find what exactly was wrong there. This might be helpful for you I think: https://symfonycasts.com/bl...
when i try to test on url /login i got this error message ClassNotFoundException in LoginFormAuthenticator.php line 22: Attempted to load trait "TargetPathTrait" from namespace "Symfony\Component\Security\Http\Util". Did you forget a "use" statement for another namespace?
so what file i must modifying to solve this issue?
Hmm. What version of Symfony are you using? I can see from your error that you ARE referring to that trait correctly (https://github.com/symfony/... so there is no reason it should be missing. Let me know!
question again so... how i use the script? copy paste in LoginFormAuthenticator? or i make a new php file?
EDIT: found it where to save that php file and i got a new error message
FatalErrorException in LoginFormAuthenticator.php line 20: Error: Class AppBundle\Security\LoginFormAuthenticator contains 1 abstract method and must therefore be declared abstract or implement the remaining methods (Symfony\Component\Security\Guard\Authenticator\AbstractFormLoginAuthenticator::getDefaultSuccessRedirectUrl)
what line makes this error is this code line
class LoginFormAuthenticator extends AbstractFormLoginAuthenticator
Oh, that comes from extending AbstractFormLoginAuthenticator class, you only have to implement such method and that should be it (But I may be wrong because you are on such an old Symfony version)
I am getting the error "You must configure the check path to be handled by the firewall using form_login in your security firewall configuration." with Symfony 4 - and after updating the LoginFormAuthenticator.php
I had login logout working via the "bin/console make:auth" but want to use the extra features from FOSUser. I can't get guard: authenticators: to work
Sorry for the delay. I'm not sure if I understand you right. Before adding FOSUserBundle your authenticator was working fine but after installing you started seeing that error?
A coupe of issues Im having, using Symfony 4.First IntelliJ is unhappy with the line - "class LoginFormAuthenticator extends AbstractFormLoginAuthenticator" with "class must be declared abstract or implement method supports" ... I now notice there is no supports method in this example, as there is in the new Symfony 4 Security tutorial. It seems like you've put the path/POST check in getCredentials. - This in turn is highlighting the "return" in getCredentials and saying "Missing return argument".
I've updated the other parts of this LoginFormAuthenticator for Symfony 4, but not sure what to do about the above parts.
Yes! You've actually done a really nice job summarizing the changes. Here are some details to help:
1) In Symfony 3, supports() didn't exist - only getCredentials()
2) In Symfony 4, getCredentials() was split into 2 methods: getCredentials() and supports(). Supports() controls whether or not your authenticator should be used on this request.
Basically, you'll move the beginning of getCredentials() into supports, but return true/or false
public function supports(Request $request)
{
$isLoginSubmit = $request->getPathInfo() == '/login_check' && $request->isMethod('POST');
if (!$isLoginSubmit) {
// skip authentication
return false;
}
return true;
}
Then, the first lines you'll need in getCredentials() will be the $username = lines.
Let me know if that helps! I hope it keeps you moving ;). Btw, you should also check out the new "php bin/console make:auth" command - as of about 1 hour ago, it can generate you a full login form system (without even needing FOSUserBundle).
Hey, I'm trying to implement FOSUserBundle with guard on Symfony 4.1.
As steevenDS pointed out there are 2 errors with the constructor type hints : EntityManager and PasswordEncoder that need to be set to their Interface counterparts.
A new function needs to be implemented as well, the supports function, we remove the isLoginSubmit logic from getCredentials and put it inside this new function :
/** * Does the authenticator support the given Request? * * If this returns false, the authenticator will be skipped. * * @param Request $request * * @return bool */ public function supports(Request $request) { if($request->attributes->get('_route') !== 'fos_user_security_login'){ return false; } }
Once all that is done, the old configuration commented out and replaced by :
Hi, thanks for this awesome tutorial, i'm working with symfony 3.4, FOSUserBundle and guard it's not working, i don't know why, i have tried to found solutions but nothing...
Cannot autowire service "app.security.login_form_authenticator": argument "$em" of method "AppBundle\Security\LoginFormAuthenticator::__construct()" references class "Doctrine\ORM\EntityManager" but no such service exists. Try changing the type-hint to one of its parents: interface "Doctrine\ORM\EntityManagerInterface", or interface "Doctrine\Common\Persistence\ObjectManager".
Hm, try to typehint your $em argument with "Doctrine\ORM\EntityManagerInterface" interface as suggested in error message, do you still have the same problem? Not sure 100% but probably Doctrine\ORM\EntityManager alias was removed that caused some BC breaks.
I've just replace in constructor the typehint for $em with EntityManagerInterface and $passwordEncoder with UserPasswordEncoderInterface. Thanks, don't have errors now, but i don't know if it's working ! ;o)
Haha, well, if you don't see an error - it should work, but would be cool to have a functional test on it to be sure ;) Let us know if it does not work.
Cheers!
Please, log in to vote for this comment
|
Share Comment
"Houston: no signs of life" Start the conversation!
24 Comments
I replaced the default login form from
FOSUserBundleby a form created with the Symfony form builder. Here is the code for this new login form:`namespace App\Form;
use Symfony\Component\Form\AbstractType;
use Symfony\Component\Form\FormBuilderInterface;
use Symfony\Component\Form\Extension\Core\Type\EmailType;
use Symfony\Component\Form\Extension\Core\Type\PasswordType;
use Eo\HoneypotBundle\Form\Type\HoneypotType;
use Symfony\Component\OptionsResolver\OptionsResolver;
class LoginFormType extends AbstractType
{
}`
Since I'm already generating my form using the Symfony's form builder mechanism, and this one gives me out of the box CSRF protection. Do I still need to get and check the CSRF token in my Guard
LoginFormAuthenticatorwith this?`$csrfToken = $request->request->get($form->getName())['_token'];
if (false === $this->csrfTokenManager->isTokenValid(new CsrfToken('authenticate', $csrfToken))) {
}`
Hey Elvism,
If you use Symfony Forms for it - it will automatically check the CSRF protection on $form->isValid() call, so as long as you call isValid() method - you don't need to check for CSRF manually, just make sure that the CSRF protection is enabled for that form - you should have that hidden _token field rendered.
P.S. Symfony Forms FTW! :)
Cheers!
Hi Victor,
Thanks for the feedback! So that means I DO NOT need to check $form->isValid() call inside my `LoginFormAuthenticator` class, my Symfony form will internally check for it as it comes built-in, and enabled by default. Is my assumption correct?
Hey Elvism,
Wait, you do need to call $form->isValid() somewhere before you will extract some data from the submitted form. CSRF protection is checked on isValid() call, and you should call it, Symfony does not call this method internally by itself.
Cheers!
Hi Victor,
Thanks for clarifying, so it's the opposite from what I was thinking.
Now this prompts me to another question. If $form->isValid() will return me only a boolean (true/false) how can I know exactly what failed in my form? If CSRF protection is what has failed, I want to get a "CSRF invalid token" message on the login form.
I'm looking for something like $form->isValidCSRF() or a way to verify the submitted token by this form which is created using the Symfony's Form builder.
Cheers,
Hey Elvism,
Well, it works in a slightly different way - see form errors instead. You can find what exactly was wrong there. This might be helpful for you I think:
https://symfonycasts.com/bl...
Cheers!
hello guys another question from me again
when i try to test on url /login i got this error message
ClassNotFoundException in LoginFormAuthenticator.php line 22:
Attempted to load trait "TargetPathTrait" from namespace "Symfony\Component\Security\Http\Util".
Did you forget a "use" statement for another namespace?
so what file i must modifying to solve this issue?
Hey Lavin Bassam!
Hmm. What version of Symfony are you using? I can see from your error that you ARE referring to that trait correctly (https://github.com/symfony/... so there is no reason it should be missing. Let me know!
Cheers!
hello im using symfony 2.8.3 and the link you give me it not currently active again
Ohh that's because Disqus thinks that the ending parentheses is part of the URL, just remove it, or click here: https://github.com/symfony/...
question again so... how i use the script? copy paste in LoginFormAuthenticator? or i make a new php file?
EDIT: found it where to save that php file and i got a new error message
FatalErrorException in LoginFormAuthenticator.php line 20:
Error: Class AppBundle\Security\LoginFormAuthenticator contains 1 abstract method and must therefore be declared abstract or implement the remaining methods (Symfony\Component\Security\Guard\Authenticator\AbstractFormLoginAuthenticator::getDefaultSuccessRedirectUrl)
what line makes this error is this code line
class LoginFormAuthenticator extends AbstractFormLoginAuthenticator
Oh, that comes from extending
AbstractFormLoginAuthenticatorclass, you only have to implement such method and that should be it (But I may be wrong because you are on such an old Symfony version)As of Symfony 4.2, is it still required to put autowire: true when registering the service?
Hey Elvism,
No, all services should be autowired as also as private by default in Symfony 4.2
Cheers!
I am getting the error "You must configure the check path to be handled by the firewall using form_login in your security firewall configuration." with Symfony 4 - and after updating the LoginFormAuthenticator.php
I had login logout working via the "bin/console make:auth" but want to use the extra features from FOSUser. I can't get guard: authenticators: to work
Hey Chalice
Sorry for the delay. I'm not sure if I understand you right. Before adding FOSUserBundle your authenticator was working fine but after installing you started seeing that error?
A coupe of issues Im having, using Symfony 4.First IntelliJ is unhappy with the line
- "class LoginFormAuthenticator extends AbstractFormLoginAuthenticator" with "class must be declared abstract or implement method supports" ... I now notice there is no supports method in this example, as there is in the new Symfony 4 Security tutorial. It seems like you've put the path/POST check in getCredentials.
- This in turn is highlighting the "return" in getCredentials and saying "Missing return argument".
I've updated the other parts of this LoginFormAuthenticator for Symfony 4, but not sure what to do about the above parts.
Hey Timothy J.!
Yes! You've actually done a really nice job summarizing the changes. Here are some details to help:
1) In Symfony 3, supports() didn't exist - only getCredentials()
2) In Symfony 4, getCredentials() was split into 2 methods: getCredentials() and supports(). Supports() controls whether or not your authenticator should be used on this request.
Basically, you'll move the beginning of getCredentials() into supports, but return true/or false
Then, the first lines you'll need in getCredentials() will be the $username = lines.
Let me know if that helps! I hope it keeps you moving ;). Btw, you should also check out the new "php bin/console make:auth" command - as of about 1 hour ago, it can generate you a full login form system (without even needing FOSUserBundle).
Have fun! Cheers!
Hey, I'm trying to implement FOSUserBundle with guard on Symfony 4.1.
As steevenDS pointed out there are 2 errors with the constructor type hints : EntityManager and PasswordEncoder that need to be set to their Interface counterparts.
A new function needs to be implemented as well, the supports function, we remove the isLoginSubmit logic from getCredentials and put it inside this new function :
/**
* Does the authenticator support the given Request?
*
* If this returns false, the authenticator will be skipped.
*
* @param Request $request
*
* @return bool
*/
public function supports(Request $request)
{
if($request->attributes->get('_route') !== 'fos_user_security_login'){
return false;
}
}
Once all that is done, the old configuration commented out and replaced by :
guard:
authenticators:
- App\Security\LoginFormAuthenticator:
Whenever I go to login I get the following error :
"You must configure the check path to be handled by the firewall using form_login in your security firewall configuration."
I have the security-bundle installed and tried going through the steps provided in the official documentation :
https://symfony.com/doc/cur...
There must be something really obvious I'm not seeing.
Any advice would be very much appreciated.
Hey DennisdeBest
Hmm, that's strange... let's double check a couple of things first
// security.yaml
security:
Hi, thanks for this awesome tutorial, i'm working with symfony 3.4, FOSUserBundle and guard it's not working, i don't know why, i have tried to found solutions but nothing...
In security.yml, i have
main:
form_login:
provider: fos_userbundle
csrf_token_generator: security.csrf.token_manager
if i replace this with
guard:
authenticators:
- app.security.login_form_authenticator
i got this error:
Cannot autowire service "app.security.login_form_authenticator": argument "$em" of method "AppBundle\Security\LoginFormAuthenticator::__construct()" references class "Doctrine\ORM\EntityManager" but no such service exists. Try changing the type-hint to one of its parents: interface "Doctrine\ORM\EntityManagerInterface", or interface "Doctrine\Common\Persistence\ObjectManager".
Thanks and sorry for my bad english.
Hey Steeven,
Hm, try to typehint your $em argument with "Doctrine\ORM\EntityManagerInterface" interface as suggested in error message, do you still have the same problem? Not sure 100% but probably Doctrine\ORM\EntityManager alias was removed that caused some BC breaks.
Cheers!
I've just replace in constructor the typehint for $em with EntityManagerInterface and $passwordEncoder with UserPasswordEncoderInterface. Thanks, don't have errors now, but i don't know if it's working ! ;o)
Hey Steeven,
Haha, well, if you don't see an error - it should work, but would be cool to have a functional test on it to be sure ;) Let us know if it does not work.
Cheers!
"Houston: no signs of life"
Start the conversation!