Void Types & Refactoring an Entire Class

Hey CISVHenriksen

I know, is not so easy to code along with the video without pausing, but maybe an extra monitor could help you get faster :)

About the login issue. I believe Ryan had in his session a redirection to the admin area after a successfully login. Symfony does it by default when you try to access a secured are when you are anonymous.

Cheers!

Yo MolloKhan!

I'll jump in here too... since I'm to blame ;). Yes, we often use that auto-complete PHP Storm trick. It's difficult because if we explain it each time, it will feel laborious after the first time... but if you haven't seen it before, it's surprising! I try to explain it when it makes sense, but it's quite imperfect :/.

About the speed, it may not always help (because when we're just talking, you may want full speed), but the video player also has a speed option. Oh, and one more thing! The code blocks are below the videos, so you can reference the code there too if it helps :).

Cheers!

Hey Virginie,

I think it's not a complete error you see, howeverI suppose you see it because sub_family_id value is null, but from the code I see nullable=false for Genus::$subFamily . So you need to find out why it is null. Is it intentionally? I think if you fixed the problem why it's null - the error will be gone.

Cheers!

I don't think it's intentional as it goes smoothly in the video, without any mention about any fix I should make for the code to run. It isn't blocking for the learning process, as I already knew SF, I could figure out why there was this issue, however, if someone who only wants to know about PHP7, without any prior knowledge on SF, has the same issue, I think he/she would be lost.

Hey Virginie,

Hm, let me see again... as I understand, you're mostly talking about this:

Apparently, the SubFamily isn't correctly retrieve on line 44 in the GenusController.
Why do you think it's retrieved incorrectly? I see:

    $subFamily = $em->getRepository(SubFamily::class)
        ->findAny('AppBundle:SubFamily');

This is totally valid as for me.


> I also have a PhpStorm warning on this line, for the findAny() method, a method not found warning
Make sense of course, because getRepository() method has "@return \Doctrine\Common\Persistence\ObjectRepository" where there're no any findAny() method, this method is from custom SubFamilyRepository. Well, If you enable and configure Symfony Plugin for PhpStorm - you won't see this warning. Or, if you don't want to use this plugin - you can manually help PhpStorm to understand better what getRepository() method returns. For example, just add an annotation manually and you won't see this warning:

    /** @var \AppBundle\Repository\SubFamilyRepository $subFamilyRepo */
    $subFamilyRepo = $em->getRepository(SubFamily::class);
    $subFamilyRepo->findAny('AppBundle:SubFamily');

> In the SubFamilyRepository, I have aPhpStorm warning in the findAny() method as an unhandled UniqueResultException.
Yes, this is a new feature for PhpStorm. This exception will be thrown if your query returns more than one row in getOneOrNullResult(), and we really do not want to catch and handle this error because this should never happen since we call setMaxResults(1).


> At the end, I still don't get any result for a SubFamily in the GenusController, thus, I have this error.
This one is interesting... Do you think we missed something in this screencast or this is just your error, i.e. you just missed something when following our tutorials? Do you have an idea how we can improve this? Because for me it looks like you just forgot to load fixtures that's why findAny() returns null for you, and it seems like a user error.


Would be glad to make a quick fix if there's really a missing part in our process.

Cheers!