Type Hinting?!

Yo Max S.!

There is a fix! And great question - I'm kind of obsessed with getting auto-completion in PhpStorm (it also helps me know when I'm doing something right versus wrong).

So, the $ship1 and $ship2 variables come from the $ships variable near the top of the file. The summary looks like this:

$ships = get_ships();
// ...
$ship1 = $ships[$ship1Name];
$ship2 = $ships[$ship2Name];

If we could somehow tell PhpStorm that the get_ships() method returns an array of Ship objects, then it would be smart enough to know that $ship1 and $ship2 must themselves be Ship objects (since we fetch them from $ships with array keys). To do that, add this above get_ships()``

/**

• @return Ship[]
  */
  get_ships()
  {
  // ...
  }

The [] after is what says "this is an array of Ship" objects.

Let me know if that helps!

Super awesome! I think I am going to join your obsession :D Thank you very much!

Hey Si Y.

What error were you getting? You need to add the isset() check because it's possible that the field ship1_quantity is not submitted.

Cheers!

The code wasn't actually erroring. It was working by redirecting back to index with a $GET suffix because the 'ship1_quantity' field in the $POST was an empty string. Changing the isset check to a !empty check catches the empty string as well as the existence of the variable. (Did I get that right?) You can check it in the code, it fails if the quantity fields are left blank (empty strings rather than nulls).

Ohh, yes, you are totally right, the empty() allow you to "access" to undefined index of arrays without throwing. That's nice :)

So, yes, if you do that change then, $ship1Quantity will default to 1. Nice debugging! Cheers!

Actually, it's XDebug - it's a PHP extension. I highly recommend installing it on your development machine :)