ApiProblemException and Exception Handling

You're right! I've fixed it at https://github.com/knpunive.... Thanks!

Hi Pietrino!

You're basically right that $this->error() is equivalent to registering a listener on the "kernel.exception" even (you said, "event.exception", but I know what you meant!). But in Symfony, you are passed a "GetResponseForExceptionEvent" event object to your method. The following code will get you what you need:

public function onKernelException(GetResponseForExceptionEvent $e)
{
   $exception = $e->getException();
   $code = $exception instanceof HttpExceptionInterface ? $exception->getStatusCode() : 500;
  // now go crazy! Create the response!

    $e->getResponse($response);
}

Silex basically does this to get the status code for you and then calls your callback that you passed to error().

Cheers!

Thanks, it worked like a charm! :)

I can't immediately think of a problem with this. If you try it out, let me know if you run into anything ugly :). The reason was just a natural evolution: I wanted to model the ApiProblem first... and then later, I was worrying and handling exceptions. That's why I think you might be right that combining these won't be an issue.

Cheers!

What I did now is the following: I created a directory called 'Exception' in my AppBundle and created an interface called 'Exception'. This interface has one method: buildResponse. Then I created the ApiProblemException (https://gist.github.com/thejager/e2b26505aa4d2bb0b266887541f2351b ) and made it implement that interface. It basically has the ApiProblem build into it and the buildResponse method, well..., builds the response ;).

Then my ExceptionListener (I'm using Symfony 3) looks like this:

    public function onKernelException(GetResponseForExceptionEvent $event)
    {
        $exception = $event->getException();

        if($exception instanceof \AppBundle\Exception\Exception) {
            $event->setResponse($exception->buildResponse());
        }
    }

Now if I need a new exception type, for some reason, with some crazy custom Response I can just create a new exception class and make it implement the Exception interface. No need to mess with the ExceptionListener. I think it's cool but only time will tell if it actually works well ;)

Don't worry - rescued the message :). I have no idea why Disqus occasionally marks things as spam!

And yep, I like this approach - the approach if creating an interface for common exceptions (this is especially cool in a library - where that library can have every exception it throws implement some base interface). So, I like it!

Cheers!

Cool, thanks. I will do that :)

Hey I don't know if you can have anything control over it but my last comment was "Detected as spam". :(