Entity & Field Permissions

Hey @julien_bonnier!

Hmmm. I like what you tried - what is the subject? It looks like it is... maybe the FieldDto object? Hmm, yea, that's not helpful. I think what you're going to need to do is grab the User object yourself - via the AdminContext. If you inject the AdminContext, you can call getEntity() to get the EntityDto, then ->getInstance() should get the underlying object. This works because you're only using this on a form page, so the User should be the "main entity" for that page (this trick would not work on a list page).

Let me know if that helps - it looks oddly tricky to me also.

Cheers!

Hey @weaverryan

What you suggested is basically what I tried in my second example, but the problem wasn't there. My problem was that ->setPermission() only accepts a string.

So.... I took a step back and figured out I can do it with plain old PHP. It is not a nice as a chained method but at least it works...

        if ($this->isGranted(UserVoter::UPDATE_PASSWORD, $this->getContext()->getEntity()->getInstance())) {
            yield Field::new('password', 'field.password')
                ->onlyOnForms()
                ->setFormType(RepeatedType::class)
                ->setFormTypeOptions([
                    'type'            => PasswordType::class,
                    'first_options'   => ['label' => 'label.new_password'],
                    'second_options'  => ['label' => 'label.repeat_password'],
                    'error_bubbling'  => true,
                    'invalid_message' => 'user.field.password.must_match'
                ])
            ;
        }

Hey @julien_bonnier!

Yea... I think this probably fine - and simpler than what I was suggesting. My suggestion wasn't actually the same as your 2nd solution - I was thinking you would do ->setPermission(UserVoter::UPDATE_PASSWORD), then in UserVoter, grab the AdminContext. to find out which User this is. A bit more complex overall than what you ended up with.

Cheers!

Oh! I see.

But I think I will keep it like this for now, as it is less complicated.

Thanks a bunch

Hey Christophe R. !

Hmm, this is a good question. I believe you have the correct approach. The big downside is duplication... and, while I can think of a solution to that... I can't think of a GREAT solution. My first thought was to setup the main properties of the field and set to a variable. Then "clone" that, modify it for the form/view, and yield it. Unfortunately, I don't think this works because clone is "shallow", and the underlying data for the TextField is stored in a DTO (in other words, cloning will still mean that you're modifying the same underlying DTO... so it's not really a clone).

So what about this:

$nameField = function() {
    return TextField::new('name', 'Nom')
        ->setColumns(6)
        ->setHelp('Nom pour reconnaître rapidement à quoi sert la variable');
};

yield $nameField()
    ->onlyOnForms()
    ->setPermission('ROLE_SUPER_ADMIN');

yield $nameField()
    ->hideOnForm()
    ->setPermission('ROLE_ADMIN')

Effectively, we create our own "clone"... which is really a function that creates a new object each time. What do you think?

Cheers!

I know that question is quite old, but what about:

$nameFieldPermission = match ($pageName) {
    Action::INDEX, Action::DETAIL => 'ROLE_ADMIN',
    default => 'ROLE_SUPER_ADMIN'
}
yield TextField::new('name', 'Nom')->setColumns(6)
    ->setPermission($nameFieldPermission)
    ->setHelp('Nom pour reconnaître rapidement à quoi sert la variable');

Hey @julien_bonnier

I think it should work too. I'd go with any option that's easier for you or your team to read/understand

Cheers!

Sorry, missing semicolon on line 4, but can't edit