Adding Routes & Controllers

I think that autowiring in the bundle is explicitly discouraged. Another way around this is to add `<call>` to each handler with method `setContainer` (which is admittedly a pain). Tbh, idk how that works exactly (are you creating a *new* container? Nesting a container? Setting something *on* a container?) but both methods don't appear to be necessary to work with bundles which appear to account for Symfony 5 such as:
https://github.com/willdura...

Does anyone have any other input on this?!

Edit
-----
I have not personally tested that bundle out on a Symfony 5 install myself; I just read the commit comments.

Hey ash-m!

Yep, you are correct :). You CAN use autowiring in your bundle, but as a best practice, it IS discouraged. The reason is that wiring things manually helps make your bundle a bit faster (on dev mode, it would be the same in prod) and makes your service config easier to read by others because it's explicit.

> Another way around this is to add `<call>` to each handler with method `setContainer` (which is admittedly a pain).

Yes, this is basically what autowiring is doing normally in this case. So, you're doing it manually. For others, there is a larger conversation about this over here: https://symfonycasts.com/sc...

> Tbh, idk how that works exactly (are you creating a *new* container? Nesting a container? Setting something *on* a container?)

It's a really cool, but complex feature :). You're creating a mini-container that has *some* services in it. You can learn about the idea here: https://symfonycasts.com/sc...

> but both methods don't appear to be necessary to work with bundles which appear to account for Symfony 5 such as: https://github.com/willdura...

If a controller doesn't extend AbstractController - https://github.com/willdura... - then none of this is needed. The AbstractController class is what tries to use this mini-service container :).

Cheers!

Thank you for the detailed reply! I am glad you mentioned the abstract controller thing because I attempted this a again using the ADR pattern and it ended up working and I didn't know why.

THK YOU BROTHER !

Hey Mindgruve

Sorry for being late to help you out but I'm glad that you could find and share the solution. Cheers!

Hey Saif Ali Ansari!

Hmm. Before we dig in too far, this may be something simple. The error says:

> Unable to find file "@KnpULoremIpsumBundle/Resources/config/routes.xml

But you said the file is located at:

> LoremIpsumBundle/src/Resources/config/routes.xml

Try moving the Resources/ directory into LoremIpsumBundle directly - NOT inside of src/. If that doesn't help, let me know :).

Cheers!

Hey weaverryan

Thank you to reply

But i can remove from src but steel its gives same error .
i am stuck in this tutorial from last three day .

Hi Saif Ali Ansari!

Sorry for the slow reply! Ok, so let's at what's going on. First, in your config/routes/knpu_lorem_ipsum.yaml, you have something that looks like this:

_lorem_ipsum:
    resource: '@KnpULoremIpsumBundle/Resources/config/routes.xml'
    prefix: /api/ipsum

And... that's great! For our purposes, the only really important part is the path: @KnpULoremIpsumBundle/Resources/config/routes.xml.

When Symfony sees this, it looks for the location of KnpULoremIpsumBundle and then looks for the path Resources/config/routes.xml inside of it to find the file. If you're following the tutorial exactly (which it seems like you are), then your bundle lives in the LoremIpsumBundle/. Directory, this means that Symfony is looking for the file in this EXACT path:

LoremIpsumBundle/Resources/config/routes.xml

Do you have a file at this path? I'm asking because, from your original message, you mentioned that your routing file lives at:

LoremIpsumBundle/src/Resources/config/routes.xml

And this is NOT the correct path. The correct path is LoremIpsumBundle/Resources/config/routes.xml. If you DO move the file to LoremIpsumBundle/Resources/config/routes.xml and you still get the error, then there are only 2 other possibilities I can think of:

A) The KnpULoremIpsumBundle is not registered in your config/bundles.php... or it has a different name
B) The KnpULoremIpsumBundle class does not live at LoremIpsumBundle/KnpULoremIpsumBundle.php. And so, the "root directory" of your bundle is somewhere else.

Let me know what you find out :).

Cheers!

Hey triemli!

Sorry about the trouble - let's see if we can work it out :). Check out my answer here: https://symfonycasts.com/sc...

There was a subtle change in the core of Symfony, which makes this now required. Actually, I need to add a note about this to the tutorial - my fault for not doing it already!

Let me know if the solution I linked to helps - and if you want any further explanation.

Cheers!

Thanks a lot! It works!

Hey Jose carlos C.

You don't need to add the routes all over again. You need to tell the app to look into your route config file, in this case, your bundle route config.

One way is adding to the routes folder a reference for what you want:
<br />// config/routes/my_bundle.yaml<br />_my_bundle:<br /> resource: '@MyBundle/Resources/config/routes.xml'<br /> prefix: /<br />

Hope that helps.

I just don't want it to depend on the global configuration, once it's defined in the Bundle, it doesn't need to be loaded again, so I'm looking for an option if it exists in Symfony to be able to have routes from the Bundle.

Hey Jose carlos C.

Pretty interesting question =) Of course you can use recipe system, but I think it's not suitable if you have not open source bundle. But there is another way. You can try make Custom route loader, and load routes from your bundle config file. It's described a little here https://symfony.com/doc/cur...

Cheers!

Thanks for the answer. I tried that already and it <b>doesn't work</b>. I have to include the routes.yml file back into app/config/routes.yml, https://stackoverflow.com/a/36487675/2046442 which means I have to include it out of the Bundle.

But there is good news! There is a solution that you only write once and it works for all your bundles, I found it here.
https://github.com/symfony/symfony/issues/22700#issuecomment-301151130
`
bundle_routes:

resource: "../src/Bundles/*/Resources/config/routes.yml"

`

Oh! Thanks fro sharing it!

Without telling the app where are your routes I don't see a way. But you can create your config file that register your bundle route paths on the config folder as part of your bundle installation, like most of the bundles.

If you find a different workaround, please share here. I would be interested to know.

Hey Mindgruve

Thanks for you assistance with this question =) If you interested in another workaround check my answer above =)

Cheers!

Hey Yaroslav,

Actually, Symfony Flex can auto-add routes.... Are we talking about Symfony 4? For example, here's the routes for EasyAdminBundle that Flex will automatically add when you require this package: https://github.com/symfony/... - i.e. Flex just copy/paste the easy_admin.yaml file with routes into "config/routes/easy_admin.yaml" in your project, and if you have good Symfony 4 application - that file will be automatically read by the application, see "configureRoutes()" in Kernel that responsible to load those files: https://github.com/symfony/...

Did you upgrade to Symfony 4 your application from 3.x? Or did you create Symfony 4 application from scratch? Probably you missed something during your update?

Cheers!

btw, I also tried to do a routes file copy with the means of composer.json of my bundle

"scripts": {
"post-install-cmd": "php -r \"copy('Resources/config/routes.yml', '../config/routes/my-bundle.yml');\"",
"post-package-install": "php -r \"copy('Resources/config/routes.yml', '../config/routes/my-bundle.yml');\"",
"post-package-uninstall": "php -r \"unlink('../config/routes/my-bundle.yml')\""
}

but none of these worked (looks like none of these was called at all, because I tried echoing and got no output)...

Hey Yaroslav,

Well, doing so with Composer is not a correct way in my opinion.

Cheers!

hi Victor,

thank you for the prompt reply. yes, I'm using Smf 4.2, and just follow this tutorial instructions (except for manual addition of bundle's resource to app routes config).

I tried install / uninstall my bundle via composer, but the routes file was never auto-copied.

should I probably create some instructions for Flex (a recipe) so that it would know what file to copy?

Hey Yaroslav,

Ah, yes, now I see the problem. You're talking about *your* bundle, sure Flex does not know nothing about it except that it's a Symfony bundle so it just includes the bundle in bundles.php and that's it. To teach Flex that when you require your bundle Flex should copy some extra files as well - you need to create a recipe for your bundle. Recipe is just a set of instructions, you can see the same EasyAdminBundle as example: https://github.com/symfony/... . But that's the official recipe, your recipe should be in https://github.com/symfony/... repository where other non-official bundles are.

Here's more info about how to create a recipe: https://github.com/symfony/...

I hope that helps!

Cheers!

hi Viktor,

great, thank you for the reply! will surely give it a try.

thank you for your support!

You're welcome! ;)

Cheers!

Turns out i'm an idiot, when including the routes.xml file in my actual application I actually included the services.xml instead, please disregard my previous message

Hey DennisdeBest!

No worries! Let's just say that making mistakes is the best way to learn - so now you're an expert in this area ;). Good job figuring out the issue.

Cheers!

Hey Tom,

Thanks for mentioning it! Yes, it looks like we have a little discrepancy between the video and its scripts, in the video we missed that "controller" string between "knpu_lorem_ipsum" and "ipsum_api_controller". Probably not a big deal, but it might be good to know for others.

Cheers!

Hey Lucas,

Good question! You can create an entity in your bundle and even use Doctrine annotation for mapping. Then in your app that uses the bundle you can create an empty class in src/Entity/ dir that will extend the one from the bundle - Doctrine will see all the parents fields. Or even better to create a Trait in your bundle instead of a class, so you don't need to inherit any class in your app, just *use* the trait - this way is even more flexible, thanks to PHP traits.

Cheers!