Creating your own Service

Hey John,

Technically, the 2nd is the new PHP 8 syntax called "Constructor Property Promotion", but eventually in both examples a private Class property is created and set to $logger. If you're on a newer PHP version - it's better to use the new syntax as it requires less code to write and easier to read :)

Cheers!

How can the 2nd one work?

I'm getting Warning: Undefined property: App\Repository\StarshipRepository::$logger

~/Projects/starshop(master)$ php -v
PHP 8.3.21 (cli) (built: May 9 2025 06:27:43) (NTS)
Copyright (c) The PHP Group
Zend Engine v4.3.21, Copyright (c) Zend Technologies
with Zend OPcache v8.3.21, Copyright (c), by Zend Technologies

Hey Martin,

It's difficult to say exactly what the problem is with your code without seeing it. Could you share the code snippet related to the line that shows you that warning?

Cheers!

well, I'm wondering how could the second form of constructor work without setting the private property?
$this->logger = $logger;

Undefined property: App\Repository\StarshipRepository::$logger

Hey Martin,

If you're asking about this specific code block:

class TestController
{
    public function __construct(private LoggerInterface $logger)
    {   
    }
}

The answer is the new PHP syntax, that's how PHP work. You may want to read more in the official docs: https://www.php.net/manual/en/language.oop5.decon.php#language.oop5.decon.constructor.promotion

In short, that just sets the property on the class with the name of the variable you're using in the constructor method signature. I mean, that's the official PHP syntax that do that job for you instead of writing that manually like in my first example. That's it :)

I hope that helps!
Cheers!

well, why do I get the error then? I follow your code and versions, defined in composer.json

Hey Martin,

Most probably, the error is not related to the code I shared with you. Could you share the code for the specific line where you have that warning? The warning should give you the line in the file that triggers it, right? Do you see it?

Cheers!

you define logger argument public function __construct(private LoggerInterface $logger)
and at the same time access class property via $this->logger in findAll() (I'm old Java guy)
so, that's why I'm getting that error and I had to add line
$this->logger = $logger;
to constructor in order to call
$this->logger->info('Starship collection retrieved');
in findAll() method.

Hey Martin,

I'm not sure I understand how you wrote that exactly in code... so if you could share the exact code, just literally copy the code of your constructor and paste in the message - that would help a lot. But if that works for you that way - just go that way, not much important.

Cheers!

is it possible to send you screenshot?

Hey Martin,

Yes, you can upload your screenshot to a public image server like "Imgur" and then link to it in the message.

But I probably know what you mean, do you mean PhpStorm warning? I thought you were talking about PHP warning. If you have a valid syntax, like the one I shared above, and you try it and it works for you in the browser but PhpStorm still shows you some warnings complaining about that syntax and do not consider it valid - then most probably you should specify the exact PHP version in the PhpStorm settings.

Open PhpStorm Settings, and then find "PHP". Set the "PHP language level" parameter to your actual PHP version, which I see should be 8.3. Also, set the "CLI Interpreter" to the actual PHP binary path. As soon as you choose the correct PHP level there - you should not see those warnings about invalid syntax anymore.

Cheers!

oh, my bad ... please forgive me, now I see it... I forgot to write access modifier (private) in front of the LoggerInterface in the case of constructor property promotion. All of a sudden even PHPStorm is happy. Sorry again, I didn't notice it...

Hey Martin,

No problem, I'm happy to hear you were able to find the problem! Yes, that access modifier is required to make the Constructor Property Promotion work, otherwise it will be just a var inside the constructor :)

Cheers!

Hey @Mahmut-A,

This feels a bit awkward to me. Are you listing all the tasks in this twig template? If so, using a for would be better:

{% for task in NumberofTask %} {# I'd rename this variable to "tasks" #}
      <h3 class="card-title">{{ task.taskheader }}</h3>
      {# ... #}
{% endfor %}

thank you so much. I was using for loop in different way. your way is easiest:)

Hi,

yes there is task list file in behind, long data file.
so each task is listed to page.

Hey Ruslan,

Yeah, about the "static method" we mean something like public static function methodName() declaration, but that option is incorrect anyway so you had to discard it :)

Method injection is meant with another option which is "By adding it as a method argument inside the controller". So in the "By declaring it as a static method in the controller" option we didn't mean method injection.

But yeah, I see what you mean... we will try to improve that option, thanks!

Cheers!

Thanks for your course.

Hey Ruslan,

You're welcome! Our challenges are polished and reviewed with a few people, so they should be correct in most cases, but if you ever notice any issues with them - feel free to let us know! Sometimes it's easy to miss something due to human factor :)

Cheers!

Hey @Krishnadas-Pc

Do you have the Symfony Serializer installed in your project? You need something that knows how to transform Starship objects into an array

Cheers!

Hey @Krishnadas-Pc

Yes, a couple of chapters ago.
Here: https://symfonycasts.com/screencast/symfony/json-api

Cheers!

Thanks for the quick reply. I might have missed it but able to add it my own.

Hey @Mahmut-A

Perhaps there are fancy ways to handle this case, but a quick thing to try that comes to mind is to create something like a ReportStatus entity, where you track the status of your process. Then, in another service, you check for it and print on what status it currently is

Cheers!

hi

I want to contribute that I found a way to write file the status as below. so another api in controller can able to check this status.
I believe and ı learned from a master:) that ı can also use mam-cache

if ($fromButton === $topology->getActionDeploy()) {

        $process = new Process([$commandParameters[0], $commandParameters[1], $commandParameters[2], $commandParameters[3], $commandParameters[4], $commandParameters[5], $commandParameters[6]]);
        $process->setTimeout(7200000);
        $process->run();
        if (!$process->isSuccessful()) {
            file_put_contents($this->statusFile, 'deploy-failed'); // Process failed

            // turning message if command has problem, instead of using throw. later,  you can respond via 404 page
            // throw new ProcessFailedException($process);
            return 'message:Command has problem';
        }
        file_put_contents($this->statusFile, 'deploy-success'); // Process success

        // decided to see response as a object,instead of output of command
        // return $process->getOutput();
        return new Response();
    }

Great! Thank you for sharing it

Hey Mahmut,

1. That's a suggestion for you to install php-intl extension, that helps with translations. You can completely ignore it locally while developing, but it's recommended to have that on production for your website. Actually, you may want to run symfony check:req command to see if you need more changes in your setup for this Symfony app.
2. That's a basic PHP question mostly, this is the new way to create properties in your PHP classes, read more about "Constructor property promotion". This way you create class properties right in the constructor by declaring them as private LoggerInterface $logger instead of doing it manually. And so, because that's the class property - you call it via $this->logger as you do for class properties. But about $repository - that's just a method argument, i.e. a simple variable, not a class property, and so you call all variables via $.

Cheers!

Hey @Luis-HG

Double-check if the repository exists in the src/Repository folder. Oh, by the way, the name is StarshipRepository (singular) without an s

Cheers!

~/symfony7/starshop (master)$ tree src
src
├── Controller
│   ├── MainController.php
│   └── StarshipApiController.php
├── Kernel.php
├── Model
│   └── Starship.php
└── Repository

└── StarshipRepository.php

Cool, so the repository is there. The error is the extra "s" you have on its name
public function getCollection(LoggerInterface $logger, StarshipRepository $repository)

Cheers!