The Server & New IsGranted

Hey MrWilde,

If you're wondering why you jumped the v4 and upgraded Symfony directly to v5.4 - the answer is that you don't have reasonable constraints in your composer.json for Symfony versions. As you can see you have * which mean upgrade to the latest available version, i.e. in theory you should be upgraded up to Symfony 7.1 which is the latest now, but because of some PHP constraints it upgraded only to 5.4 because Symfony 6 already requires PHP 8 while you constrained it to PHP 7.x in your compsoer.json. To avoid such reckless upgrade you need to use smarter constraints for your all your symfony packages, e.g. "symfony/dotenv": "^4.4" instead of * - this will upgrade you to the latest 4.4 version and will not try to upgrade to the latest available.

Better to not jump over major versions, the strategy should be to upgrade your current major version to the latest, i.e up to 3.4 first, fix all deprecations, and only then upgrade to the next major, i.e. 4.4, then fix all the deprecations again, and next upgrade to the 5.4... and so on.

I hope this helps!

Cheers!

Hey Mattias,

It should be OK, if you prefer annotations (or PHP 8 attributes) - you can use IsGranted annotation/attribute above your controller's action. Or you can call that isGranted method explicitly in the method as you did. There is no difference, but the 1st option would make your controller cleaner (less code) while the 2nd option gives you a more control as you can write a PHP code and add more checks if needed.

Well, isGranted() PHP function will just return you either true or false, i.e. you should throw an AccessDeniedException manually to actually deny the access. Btw, it depends on what class your controller extends, but if you extends Symfony base controller - you could shorten that method call to just "$this->isGranted(...)" instead of doing it via "security.authorization_checker" service. And btw, there's another method call createAccessDeniedException() that helps to create the actual exception for you, i.e. you can do something like:

if ($this->isGranted(...)) {
    throw $this->createAccessDeniedException(...);
}

But of course, it would be great to check that your code works and you see that access denied exception in your browser :)

Cheers!

The Controller class is created like this

`
namespace AppBundle\Controller\ExtraOpening;

use AppBundle\Entity\ACRGroup as ACRGroup;
use AppBundle\Entity\ExtraOpening\DebitPeriod;
use Symfony\Bundle\FrameworkBundle\Controller\Controller;
use Symfony\Component\HttpFoundation\Request;
use AppBundle\Service\globalHelper;

/**

• Debitperiod controller.
  
  /
  class DebitPeriodController extends Controller {
  ...`

Is the Base controller you mentioned different from the <b>Symfony\Bundle\FrameworkBundle\Controller\Controller</b> I'm using?

In this particular case I did this with the logic, but I see what you're saying.

` if ( $this->get('security.authorization_checker')->isGranted('ROLE_EXTRAOPENING_ADMIN') ) {

        //If user is extraopening admin, list debit periods for all units...
        $units = $em->getRepository('AppBundle:ACRGroup')->findAll();
    } else {
        //...otherwise list only units that user has permission to work with
        $units = $user->getACRGroups();`

Hey Mattias,

Ah, yes, I was mention the Symfony\Bundle\FrameworkBundle\Controller\AbstractController - this one should have that isGranted() method. Otherwise, using a special service for this is fine, it's up to you!

Cheers!

Hey Matt,

Yes, it should work according to the docs:

> Each IsGranted() must grant access for the user to have access to the controller.

See https://symfony.com/doc/mas... . Or you can use @Security for more flexibility.

Cheers!