Updating the All-Important FrameworkBundle Recipe

Hey @shmt!

Then that issue looks legit! Since you found the fix, would you be willing to open a pull request for it on symfony/flex? If you send the link here, I can review and support it. I'm not sure why I've never hit this before, but it'd be great to fix it!

Cheers!

Hi

Yeah, that sometimes happens when you are working on windows. The best solution is configuring your editor to use LF as line endings. In PHPStorm you can do it in the bottom right corner.

Cheers

Hey Steve,

Did you notice any warnings/errors in the console when was doing that upgrade? Well, it might be so that your symfony.lock file was in not-perfect state. It happens sometimes, but that's to the "git diff" you should be able to revert your original configuration manually.

I hope this helps!

Cheers!

Thank you Victor. There were no errors in the console. I did start to get conflicts later on in some areas though. I pulled the code that was removed from a copy of the project so nothing has been lost.

Thank you

Hey Steve,

Awesome, glad to hear you nailed it. Yeah, it might be some edge cases probably, not sure if those are bugs or no. If you noticed a weird behaviour that looks like a bug and you have steps how to reproduced. it - feel free to report about it in Symfony.

Cheers!

Hey Steve,

Did you download the course code and started from the start/ directory there? It sounds like you're missing some code in your project, most probably something that were added in previous tutorials. So, I'd recommend you to follow the tutorial this way.

But what about the actual error, make sure you have this code in your config/services.yaml

services:
    # default configuration for services in *this* file
    _defaults:
        # ...
        bind:
            bool $isDebug: '%kernel.debug%'

If you have this - the autowiring should work. But also, please, make sure you typehinted that argument as "bool $isDebug" in the __construct(). And don't forget to clear the cache just in case to rule out the cache problem :)

Cheers!

i had, beside others, the same error. adding

        bind:
            bool $isDebug: '%kernel.debug%'

to servcices.yaml fixed the problem.

yes, i used the start folder from the zip.

Hey Ek24,

Thanks for confirming this configuration helped!

Cheers!

HI Victor

I did download the course code yes and have since (in the last few mins) sussed out a couple of things. I crossed referenced the "finish" code making a few tweaks (mainly the one you have suggested) and also found that PhpStorm was using php7.4. Changing this has now got me in the right place.

Thank you so much for replying

Steve

Ah, I thought you get the error in your browser :) Yes, PhpStorm also have runtime checks that are based on the PHP version you set in config, good catch!

I'm glad you got it working ;)

Cheers!

Hi,
I had the same, really confusing result. You probably also have new .git -folder in your current directory, but with only objects subdir in it?

After digging deeper what happens it seems that recipes:update does not work properly when your symfony project is in a subfolder of your git project.
(Git diff in RecipePatcher assumes you are at the root of the git project, and the same with paths to .git -folders when generating and adding the blobs.)

I think I know already how this could be fixed. But as a quick fix to get further with the course, you can try working on a git repo where you are at the root folder.

Best Regards,
Mikko

Hey Mikko,

Oh, it might be so... I personally init Git repo for all my projects in the root dir of the Symfony project, that's why I probably have never noticed it myself. Thanks for sharing this tip! Well, I'm not sure if this behaviour would be considered as a bug, but I think it's worth to be reported upstream if it has not been reported yet.

Cheers!

Hey Julien,

This does not sound like a desired behaviour... seems something went wrong, and probably the command output has more context. Btw, what command did you execute? Well, you may want to "reset" the recipe, I suppose you're talking about symfony/framework-bundle one? You can do it with

$ composer recipe:install symfony/framework-bundle --force --reset

It will force install the latest recipe overwriting the existent data, but then with "git diff" you may revert some good changes you want to keep.

I hope this helps!

Cheers!

Hum, I did reset the head and all the files and ran

$ composer recipes:update

chose symfony/framework-bundle and got the same 4 file updates only.

Then, I did a reset again to have a clean branch and ran

$ composer recipe:install symfony/framework-bundle --force --reset

which gave something closer to the expected result

You can check my setup if you want to: https://github.com/jbonnier...

Just run

$ make local-config
$ docker compose up -d

Nginx might crash if you don't have an SSL certificate in a certain path, but you shouldn't need a web server for that.

Also all my composer commands are ran in a container with

$ docker compose exec php-cli composer ...

Hey Julien,

Yeah, not sure what happened, but "recipe:install --force --reset" should do the trick because it literally just re-install the latest recipe from scratch. A trick I use sometimes if something went wrong with "recipe:update" command.

Cheers!