Adding Property Types to Entities

Hey @sansxd ,

Yeah, Rector tool should be good for this, and your rules set looks good to me too. Give it a try, but don't forget to commit changes before running it. Also, you may want to apply code styles after Rector, e.g. run PHP CS Fixer: https://github.com/PHP-CS-Fixer/PHP-CS-Fixer

Cheers!

Hi @Tim-K,

Good question, I guess you are using phpstan/phpstan-doctrine extension, if so then you can try disable this check with

parameters:
  doctrine:
    allowNullablePropertyForRequiredField: true

try to add it to your phpstan.neon

Probably this check is not comfortable, but from phpstan perspective if your column is not nullable then you should use '' empty string. I can't say is it good practice or not, however in some cases it can save you from unexpected behaviour.

Cheers!

Hey Annemieke-B!

Excellent question! I might... suggest something totally different. There is a general "best practice" out there (I don't know if it's programming-wide or just in PHP, due to our types) to avoid decimals and floats with prices. Instead, use integers.

The idea is that you store your costPrice in whatever the lowest denomination is of the currency - in other words, you store it in "cents". If something costs $45.33, you would store the integer 4533 in the database. This avoids weird things like getting strings or rounding issue (actually, the reason that it's giving you a string is to try to avoid rounding issues - e.g. 45.33 becoming something weird like 45.33000000000001 or something crazy like that). To help when rendering, you can add another getter method like getCostPriceFormatted() where you return $this->costPrice / 100 or even add a $ in front of that and return a string.

Let me know if this helps - we've absolutely done this on our site :).

Cheers!
Cheers!

Thank you Ryan for the quick response.

I knew about the cents option, that works great. Using it when I can and had some discussions about that with fellow programmers in the past.

So, this was a bad example i send you...., sorry.
So what about data that has decimals, because of other kinds of units and needs to be imported via a cronjob/command? E.g. laboratory data, with all kinds of units i have no knowledge of.

I'd really like to know how you would handle this.
Thank you!

Annemieke

Hi @Annemieke!

Sorry for my very slow reply!

E.g. laboratory data, with all kinds of units i have no knowledge of.

Hmm. I don't have a lot of first-hand experience with floating-point calculations in PHP. But I do know that the reason Doctrine returns a string with a decimal type is exactly because it doesn't trust php to keep the exact precision if it returns it as a double. From their docs:

For compatibility reasons this type (decimal) is not converted to a double as PHP can only preserve the precision to a certain degree. Otherwise it approximates precision which can lead to false assumptions in applications.

And the float Doctrine type is not meant for exact precision. So, double seems correct to me from a Doctrine perspective... simply because it uses a string, so we don't have the precision problem with using an actual number type in PHP. Then, if you need to do more than just print that number (e.g. you need to do some calculations), I imagine that is why php-decimal exists.

I hope this helps :).

Cheers!

Thank you Ryan! This helped.

And where exactly is this tool? I cannot find it to save my life. =S

Howdy!

If I have a class like:

class One
{
    public $alpha;
    public $beta;

    public function __construct(string $alpha, array $beta)
    {
        $this->alpha = $alpha;
        $this->beta = $beta;
    }
}

I believe Steve is referring to the ability to right-click on a property ($alpha) -> selecting Show Context Actions -> selecting the "arrow" next to Add 'string' as the property's type -> selecting "Fix all 'Missing property's type declaration' problems in file.

Enjoy!

This does do the same thing, I think I'm so used to using the keys and that is how I came upon the fix but now I know this route I may change... Adopt Adapt and Improve :)

Cheers Jesse

In an entity class PHPStorm under lines properties if there is no property type specified.
I place the cursor on the property in question then (I'm on a Mac) hold down the option key and press enter

A menu pops up and the first option is "add [INSERT TYPE] as the property type. You can select this to complete or press the right arrow to expand the menu. The second option in this menu allows you to "Fix all missing property type" within the class

I hope I've explained this correctly.

Steve

It seems like a time-saver, but it is ignoring the recommendation given in this video to use type Collection instead of ArrayCollection:


That makes sense to me.

Thanks Steve!

Hey Steve D.

Good observation. Using PHPStorm to autocomplete your code is very useful, I use it as much as I can so I can save time and focus on the important things. I think Ryan don't use it too much avoid confusion and show exactly what's he doing

Cheers!