Implementing More Actions

Hey @Jeff_Merlu, great question!

You could totally have your actions be services, then inject as a container into the console command class. The AutowireLocator attribute would make this a cinch. As a bonus, these services would be lazy, they wouldn't be instantiated until actually used.

You would need to change ActionCommandInterface::execute() to accept all the required arguments (instead of injecting these in the constructor). Then to get the correct action, instead of the match, you'd do something like the following:

$playerAction = $this->actions->get($actionChoice)

Then, execute the action with:

$playerAction->execute($player, $ai, $fightResultSet)

Hope that helps!

Besides what @kbond suggests (which is a nice way to deal with it) you could implement a "CommandFactory" and delegate all the instantiation logic, it is a good option if you don't want to inject the whole commands collection into your service. You would use the factory like this

class CommandFactory
{
    public function createAttackCommand(Character $player, Character $ai, FightResultSet $fightResultSet)
    {
        return new AttackCommand(
            $this->serviceOne,
            $this->serviceTwo,
            $player,
            $ai,
            $fightResultSet
        );
    }
}

$playerAction = $this->commandFactory->createAttackCommand($player, $ai, $fightResultSet);

This is just a quick example, you can modify/improve any part of it. By the way, we'll talk about the Factory pattern in this tutorial :)

Cheers!