File Uploads & Data Fixtures

Hey Aurélien Dachier!

Hmmm. Do you have any config in your services.yaml file for UploaderHelper? And also, does your "bind" line look like this? https://symfonycasts.com/screencast/symfony-uploads/uploader-service#codeblock-9d72416900

Usually, this error would make me think that you have some config that makes it look like "uploadsPath" is a service - some config like:

services:
    _defaults:
        bind:
            $uploadsPath: '@uploadsPath'

Or perhaps:

services:
    App\Service\UploaderHelper:
        arguments:
            $uploadsPath: '@uploadsPath'

Let me know what you see in your services.yaml file :).

Cheers!

Hi ! Thanks for your answer, here's what i have in my services.yaml file :

parameters:
    app.path.product_images: /uploads/images/products
    app.path.event_image: /uploads/images/events

services:
    # default configuration for services in *this* file
    _defaults:
        autowire: true      # Automatically injects dependencies in your services.
        autoconfigure: true # Automatically registers your services as commands, event subscribers, etc.

    # makes classes in src/ available to be used as services
    # this creates a service per class whose id is the fully-qualified class name
    App\:
        resource: '../src/'
        exclude:
            - '../src/DependencyInjection/'
            - '../src/Entity/'
            - '../src/Kernel.php'
            - '../src/Tests/'

    App\Service\UploaderHelper:
        class: App\Service\UploaderHelper
        arguments: 
            $uploadsPath: '@uploadsPath'
            $requestStackContext: '@requestStackContext'

    # add more service definitions when explicit configuration is needed
    # please note that last definitions always *replace* previous ones

Did I make something wrong ?

Hey Aurélien Dachier!

Excellent - this is very useful! When you have the @uploadsPath value in this file, it tells Symfony to look for a service whose id is uploadsPath, which is not what you're intending. My guess is that you actually want to pass in one of those two parameters. In that case, you would use something like $uploadsPath: '%app.path.product_images%'.

Let me know if that helps :).

Cheers!

Hey Jean M.!

I think it's a fine approach :). It's not the one I prefer - but there is not super important reason for that. The thing I don't like about the entity solution (though, again, it's not such a major detail) is that it requires you to have a property on your entity that exists *just* to temporarily hold the UploadedFile - it's not meant to be persisted. Using an unmapped field in a form removes the need for this property.

The other thing that I don't prefer with lifecycle callbacks for this, is that it requires all of your logic to be inside of your entity - but I would usually prefer to have this logic in a service. This also limits you to saving things to the local filesystem - you can't use something like Flysystem, because you can't access services from inside your entity.

So, I see the lifecycle events approach to file uploading as a simpler, easier way of doing things. But I personally prefer to split things up a bit more, just because I like to have the logic in a service. But it sounds like you have had a lot of luck with the simpler approach - which does not surprise me. So if you want to keep doing it, no complaints from me ;).

Cheers!

Ok, it was an old tutorial, an easier way for basic usage i think but services are better way for customization. No problem for changing my paradigm. So i continue the course.

Thanks!

Hey TomaszGasior

That's a good point, I think you could use that flag argument if you want but I don't see the uploading logic being polluted with fixtures logic, all the pesky details of copying files live inside fixtures

Cheers!

Hey Manoj,

Thank you for your feedback! We're really happy you like it and it's useful for you ;)

Cheers!