Hunting the Final Deprecations
Keep on Learning!
If you liked what you've learned so far, dive in! Subscribe to get access to this tutorial plus video, code and script downloads.
With a Subscription, click any sentence in the script to jump to that part of the video!
Login SubscribeHow can we be sure all our deprecated code is gone? The easiest way to catch most things is to surf around your site to see if you can trigger any other deprecation logs. Except... if a deprecation happens on a form submit where you redirect after... or if it happens on an AJAX call... you're not going to see those on the web debug toolbar.
Checking Deprecated Logs Locally
Fortunately, deprecations are also logged to a file. At your terminal, run:
tail -f var/log/dev.log
Symfony writes a lot of stuff to this log file... including any deprecation warnings: "User Deprecated". Hit Ctrl
+C
to exit the "tail" mode and run this again, but this time "pipe" it to grep Deprecated
:
tail -f var/log/dev.log | grep Deprecated
We're now watching the log file for any lines that contain Deprecated. Unfortunately, because of that annoying doctrine/persistence
stuff, it does contain extra noise. But it'll still work. You could filter that out by adding another | grep -v persistence
.
Anyways, now we can try out the site: like clicking into an article... or doing anything else you can think of, like going to an admin section /admin/comments
. Oh, duh - I'm not logged in as an admin. You get the point: use your site, then go back and check out the deprecations.
Yikes! I probably should have added that | grep -v persistence
to remove all the noise. But if you look closely... yea... every single one of these is from doctrine/persistence
!
So as best as we can tell, our site is deprecation free. But! There are a few more things to check to be sure.
Command Deprecations
For example, if you have some custom console commands, they might trigger some deprecated code. Open a new terminal tab and run:
php bin/console
This app has two custom console commands. Let's run this article:stats
command... it just prints out a fake table:
php bin/console article:stats foo
It worked perfectly. But if you go back to the logs and look closely... ah! A real deprecation warning!
ArticleStatsCommand::execute()
return value should always be of the typeint
since Symfony 4.4, NULL returned.
Interesting. Let's open that command: src/Command/ArticleStatsCommand.php
:
// ... lines 1 - 11 | |
class ArticleStatsCommand extends Command | |
{ | |
protected static $defaultName = 'article:stats'; | |
protected function configure() | |
{ | |
// ... lines 18 - 22 | |
} | |
protected function execute(InputInterface $input, OutputInterface $output) | |
{ | |
// ... lines 27 - 48 | |
} | |
} |
Since Symfony 4.4, the execute()
method of every command must return an integer. At the bottom, return 0
:
// ... lines 1 - 11 | |
class ArticleStatsCommand extends Command | |
{ | |
// ... lines 14 - 24 | |
protected function execute(InputInterface $input, OutputInterface $output) | |
{ | |
// ... lines 27 - 49 | |
return 0; | |
} | |
} |
This ends up being the "exit code" that the command returns when you run it. Zero means successful and pretty much anything else - like 1 - means that the command failed.
Copy the return and open the other command class. At the bottom of execute()
, return 0
:
// ... lines 1 - 14 | |
class AuthorWeeklyReportSendCommand extends Command | |
{ | |
// ... lines 17 - 38 | |
protected function execute(InputInterface $input, OutputInterface $output) | |
{ | |
// ... lines 41 - 61 | |
return 0; | |
} | |
} |
And... let's make sure that we don't have any other return statements earlier. Nope, it looks good.
Production Deprecation Log
So we've surfed the site, checked the logs and run some console commands. Now are we sure that all the deprecated code is gone? Maybe? There are 2 final tricks.
First, as I mentioned earlier, at this point, I would deploy my code to production and watch the prod.deprecations.log
file for any new entries... ignoring any doctrine/persistence
stuff:
monolog: | |
handlers: | |
// ... lines 3 - 15 | |
deprecation: | |
type: stream | |
path: "%kernel.logs_dir%/%kernel.environment%.deprecations.log" | |
// ... lines 19 - 24 |
If nothing new is added, it's almost definitely safe to upgrade.
Deprecations in Tests
Another easy trick is to... run your tests! You... do have tests, right? Run:
php bin/phpunit
For me, it looks like it needs to download PHPUnit... and then... cool! This collects all the deprecations that were hit inside our tests and prints them when it's done. There are a lot of doctrine/persistence
things... but that's it! There are no Symfony deprecations.
I am now willing to say that our app is ready for Symfony 5.0. So... let's upgrade next! Thanks to all our hard work, upgrading to a new major version of Symfony is just a Composer trick.
There is one more deprecation that happens when you run the command
bin/console article:stats
with the following error messagephp.INFO: Deprecated: Array and string offset access syntax with curly braces is deprecated {"exception":"[object] (ErrorException(code: 0): Deprecated: Array and string offset access syntax with curly braces is deprecated at /Users/dontas.tassis/Projects/symfony-upgrade-4-5/vendor/michelf/php-markdown/Michelf/MarkdownExtra.php:677)"} []<br />
After a bit of research I found that the current latest version of KnpMarkdownBundle 1.8.1 has a composer dependency with michelf/php-markdown : ~1.4 which causes the deprecation. The latest library needs to be updated. Is that possible to happen as a KnpMarkdownBundle dependency or the library it self has to be updated?