Attachments with Async Messenger Emails

Hey Kiuega!

Hmm, I see! Yea, this is "screwy" - I would love to fix this problem properly in WebpackEncoreBundle (which I maintain), but it is tricky!

Here is one thing to try is this: add an event listener to the MessageEvent - https://github.com/symfony/symfony/blob/5.x/src/Symfony/Component/Mailer/Event/MessageEvent.php

This will actually be fired both (right before) the message is queued and also (right before) the message is actually delivered (in the worker). Try doing the entrypoint reset there. If you want to be more specific about it, you could check $event->getEnvelop() on the event object and see if it has a ReceivedStamp. If it does, then it is being handled by a worker and is about to actually be delivered. If not, then it is not being sent but is just being queued.

Let me know if that works!

Cheers!

Hey Ryan! Thank you for your answer!

I followed your directions, so here's what I get:

class MessageEventListener implements EventSubscriberInterface
{
    private $entrypointLookup;

    public function __construct(EntrypointLookupInterface $entrypointLookup)
    {
        $this->entrypointLookup = $entrypointLookup;
    }

    public static function getSubscribedEvents()
    {
        return [
            MessageEvent::class => 'onMessage',
        ];
    }

    public function onMessage(MessageEvent $event)
    {
        $this->entrypointLookup->reset();
    }
}

It works great!

On the other hand to check if the event contains a ReceivedStamp, I have some difficulties.

In fact the line $event->getEnvelope() seems returns this object:

Symfony\Component\Mailer\DelayedEnvelope and not Symfony\Component\Messenger\Envelope

So, we have this one :

MessageEventListener.php on line 27:
Symfony\Component\Mailer\DelayedEnvelope {#6072 ▼
  -senderSet: false
  -recipientsSet: false
  -message: Symfony\Bridge\Twig\Mime\TemplatedEmail {#6062 ▼
    -htmlTemplate: "stripe/email/admin/admin_message_to_customer.html.twig"
    -textTemplate: null
    -context: array:1 [▶]
    -text: null
    -textCharset: null
    -html: null
    -htmlCharset: null
    -attachments: []
    -headers: Symfony\Component\Mime\Header\Headers {#6077 ▶}
    -body: null
    -message: null
  }
  -sender: null
  -recipients: []
}

I was planning to use this kind of line to see if there was a ReceivedStamp:

if($envelope->last(ReceivedStamp::class)) {
            //...
    }

But how could I verify it with this object? Does it allow me?

Hey Fabrice!

Ok! One step forward, one more to go :).

About the Envelope, that's my fault: I completely mis-read how the core code works. This is not a Messenger Envelope that we're talking about in this case - it's a "Mailer" envelope. With that in mind, I think what you need to use is simply $event-> isQueued(). If I'm reading the code correctly (no guarantee) that should be true when the message is about to be queued (and not actually sent) and false when the worker processes it and it's actually about to send :).

Let me know if this helps get that last piece!

Cheers!

Yes it was that ! Good game ! :D

Hey apphancer

I'm not sure if there are any callbacks you can hook into, you may want to investigate a little bit but what you can do is to make the *handler* to dispatch another message (the CleanUp message) when it finished its work

Cheers!

Hey Thibault V.!

Hmm. Just so I'm clear: the issue is that you really want to pass a path that should be processed through Flysystem, right? If so, the problem is that, when the Mailer system eventually tries to read your file, it doesn't know to use Flysystem: it just does an fopen on your file path: https://github.com/symfony/symfony/blob/09645a9103a4eb55c8ff081ea8632179c408dce9/src/Symfony/Component/Mime/Part/DataPart.php#L59

Unfortunately, there's no "simple" way to pass a path that would be resolved later via Flysystem. To do this you could:

A) Register a stream wrapper and pass a path that uses it - e.g. s3://path/to/file
B) Do NOT add an attachment, but instead, create a custom Email class (that extends TemplatedEmail) and set some new/custom property on it that indicates which file should be attached. Then, add a listener to MessageEvent that reads this property and uses it to add the attachment (using a normal attach()). The idea is that this code would run when the email is being sent in the queue. The only trick is that this event (I believe) is also dispatched when the email is originally being queued, so you would need to somehow differentiate between "is this email being queued" and "is this email being sent".

Or, if I've misunderstood somehow and this is working... but it just breaks when running from the queue, let me know :).

Let me know if any of this makes sense ;).

Cheers!

Hey weaverryan,

Thanks for getting back to me ! You understood correctly and i'm in fact trying to attach files from google cloud storage inside some emails.

I'm going to check out the second option for now as it is clearer for me but I would love to know more about the stream wrapper. How would you go about implementing it ? (in my case it would be gs:// ;) )

However, since fopen can accept a URL, I'm actually thinking of passing a signed url to the content on cloud storage. I'm finishing another project and haven't had time to test it. What do you think about this ?

Thanks for your feedback :)

Hey Thibault V.!

Ah, signed URL seems like a really interesting idea! The gs:// is a variation of that - you can basically make it so that gs://some/path uses custom logic in your code to fetch this some/path and things like fopen will understand it. It looks like Google Cloud might already support this in their SDK? https://github.com/googleapis/google-cloud-php/blob/master/Storage/src/StreamWrapper.php Or somebody (it's a bit old) added a library to use a stream wrapper with Flysystem https://github.com/twistor/flysystem-stream-wrapper/

Let me know what you figure out!

Cheers!

Hello weaverryan,

I'll look into it and get back to you when I finally get around this feature.

Thanks again !

Hey Kevin B.

It should be sent immediately if you haven't configured messenger routing for Mailer message. But I guess you are looking in Symfony profiler and there is some not exact information.

Cheers!

Hey sadikoff, I was thinking more if you had messenger routing setup but want an important email to be sent immediately, skipping the queue.

I looked into this further and I don't think it's possible.

hm I think it's possible, something like configuring sync transport, route message to both transports sync and async, but configure handler to process messages depending on transport. Here is a clue for you https://symfonycasts.com/sc...

Cheers!

Hey AymDev,

What actual number of count do you have? Is it "0"? Yeah, testing async is a pain :) Because, to actually send the email you need to run worker with "bin/console messenger:consume" command. And anyway, you need to worry about not sending real emails in test mode, because you don't want to hit real users inbox while testing.

Cheers!

Yes I actually have 0 emails sent.
Oh okay that explains it, the message is dispatched but as long as it isn't processed it doesn't count as sent. Seems legit :)

Thank you again for your answers, cheers !

Hey AymDev,

Yes, exactly! Sounds legit for me too :)

Cheers!