Processing Encore Files through inline_css()

Hey be_tnt!

So.... I am aware of a potential issue that you could be hitting. You don't have quite the setup I would expect for that problem... but it's close enough that I think it's the same.

First let me ask: it sounds like you are using messenger to send your emails asynchronously, is that correct? You are "routing" the messages to a messenger transport, then the emails are actually sent when you run the messenger:consume command, right?

The problem (I believe) is that your email is being rendered twice. And the second time it's rendered, because Encore thinks the CSS & JS have already been "output", the getCssFiles() method returns an empty array. You could verify that this the cause by adding this line right after the getCssFiles() call:

$this->container
    ->get(EntrypointLookupInterface::class)
    ->reset()

If that fixes the problem, then this is the problem :). Let me know if it helps - and then we can debug further. I mean, having the "reset" is a "fine" thing to keep there - it won't hurt anything (it just shouldn't be needed). From my research, there is a problem when Messenger is installed, but emails are still handed synchronously - ir I remember correctly, Mailer dispatches an event 2 times in one request... they both render the message... and voila! The second one has no CSS. It's (I believe) actually a subtle bug in Symfony that you only see when using Encore. But, let me know what you find out.

Cheers!

Hi weaverryan !

You were completely right. I am indeed sending the emails asynchronously with thee messenger:consume command. After adding the suggested line after the getCssFiles(), the css was inlined again in my mail :)

thx!

Hey weaverryan!

Old post, but I stumbled upon the same error without using Messenger:
When a user submits a form and selects one special value, a first email is sent to the user AND a second one to an admin group - which then gets no styling...
This one was hard to catch, esp. as the mail rendered fine in a DevController to display all mails in an iframe and in tests.

I solved this by wrapping getEncoreEntryCssSource in a cache->get() call (AND resetting EntryPointLookupInterface ;)

    public function getEncoreEntryCssSource(string $entryName): string
    {
        $cache = $this->container->get(CacheInterface::class);
        $cacheKey = __FUNCTION__ . ';' . $entryName;

        return $cache->get($cacheKey, function (ItemInterface $item) use ($entryName) {
            $item->expiresAt(null);
            $entryPointLookupInterface = $this->container->get(EntrypointLookupInterface::class);
            $entryPointLookupInterface->reset();
            $source = '';
            foreach ($entryPointLookupInterface->getCssFiles($entryName) as $file) {
                $source .= file_get_contents($this->publicDir . '/' . $file);
            }

            return $source;
        });
    }

Regarding this lesson:
It is nice to have the "Tip" at the end, but:

• it is not about Messenger at all (it happens when 2 or more mails are rendered in the same request) </li>
• it should be a warning at the top </li>
• maybe getEncoreEntryCssSource could also simply include the reset() call, so this warning is not even needed </li>

What do you think?

(jesus, Disqus should simply use Markdown :)

Hey boedah!

> (jesus, Disqus should simply use Markdown :)

Yea, we're replacing Disqus right now - we hate it too ;).

> * it is not about Messenger at all (it happens when 2 or more mails are rendered in the same request)

Good point!

> * maybe `getEncoreEntryCssSource` could also simply include the `reset()` call, so this warning is not even needed </li>

Even better point! I really like that idea!

I'm going to propose a modified note to use your solution. I appreciate it - great thinking!

Cheers!

👍

Issue seems still there, I am not using Messenger and I got the same issues. Reset is required.
This is also processing twice.

Hey Florent,

Yes, you're right, you still need that reset(). It's not a bug, it's just a limitation... a compromise to make WebpackEncoreBundle great in other cases :)

Cheers!

Not a problem ;) I think it should appear in tutorial.

Hey Florent,

Agree! And it IS in the tutorial ;) See https://symfonycasts.com/sc...

Cheers!

This is another tutorial :D
I am not generating a PDF for now (but I will, surely)
And reset is not fixing the twice rendering.

Hey Florent,

I'm confused, we're talking on https://symfonycasts.com/sc... page, and I linked to https://symfonycasts.com/sc... page, so both pages are chapters of https://symfonycasts.com/sc... , or am I missing something here? :)

> And reset is not fixing the twice rendering.

Actually, the purpose of reset() is the opposite, every time you call reset and then render encore assets - it will render all the assets again. And this workaround is needed because Webpack Encore avoid rendering same assets twice.

Cheers!

Is there more information on this issue anywhere? Why the double rendering when using Messenger? Thanks

Hey Benr77!

I believe this is the related issue - https://github.com/symfony/... - I've just bumped it :).

Cheers!

Hey TigerShark,

No, at least not yet :) AssetMapper comes with importmap() Twig function, and you can also leverage the asset() Twig function to link to your assets.

Cheers!

Hi @sabat24!

> Even if you use messenger in sync mode, EntrypointLookup has to be reset

Yes, I think that may be correct: when Messenger is installed, even if you're sending the emails sync, Symfony does the odd double-render. I really need to make handling this easier in WebpackEncoreBundle (which I maintain), but it's a tricky issue to get right :/.

> What's more in SF 5.2 the ServiceSubscriberInterface doesn't work any more. EntrypointLookup should by DI in constructor

You can definitely inject through the constructor, but I'm not aware of any changes in Symfony 5.2 related to ServiceSusbcriberInterface - that interface still exists and should still work exactly like before. If you're having any trouble with it, let me know and we'll see if we can debug :).

Cheers!

When I tried to use ServiceSusbcriberInterface I received following error:

<blockquote>Symfony\Component\DependencyInjection\Exception\

                ServiceNotFoundException                

The "Symfony\WebpackEncoreBundle\Asset\EntrypointLookupInterface" service or alias has been removed or inlined when the container was compiled. You should either make it public, or stop using the container directly and use dependency injection instead.
</blockquote>

And this is the line which causes the problem

$files = $this->container
            ->get(EntrypointLookupInterface::class)

<blockquote>Container->make('Symfony\WebpackEncoreBundle\Asset\EntrypointLookupInterface', 1)

        in
            D:\wamp\www\wildq2\vendor\symfony\dependency-injection\Container.php
                    (line 228)

</blockquote>

    public function get($id, int $invalidBehavior = /* self::EXCEPTION_ON_INVALID_REFERENCE */ 1)
    {
        return $this->services[$id]
            ?? $this->services[$id = $this->aliases[$id] ?? $id]
            ?? ('service_container' === $id ? $this : ($this->factories[$id] ?? [$this, 'make'])($id, $invalidBehavior));
    }

You can ignore that error above. I used wrong ContainerInterface. It was DependencyInjection one instead of Psr\Container. Everything works fine.

Hey Usuri,

If you send the email sync, then you should have access to the rendered HTML via $mail->getHtmlBody() method - call it right after the "$this->mailer->send($mail);" call. The renderer will render the template and set its HTML on the same email object.

If you send async - you probably need to do this via Messenger component.

I hope this helps!

Cheers!

Hey Kiuega,

Good question! Well, BCC is not quite for this. When you use BCC - you suppose to send the exact same email to the email addresses specified in BCC, but in your case you're going to send a different unique emails. They are unique because of the unique user name in the email.

I think the only way to achieve "group emails" is to use Sendgrid API (or other service API you're using). For Sendgrid - take a look at Bulk Email Service: https://sendgrid.com/docs/g... . Usually, each email service gives you its own implementation of this, and it may vary from service to service.

Otherwise, you can try to make the email the same for every user and use BCC. Or, create unique emails for every user and send them separately. You may want to use Messenger integration in this case that will help with sending them async behind the scene.

I hope this helps!

Cheers!